| From: | John Naylor <johncnaylorls(at)gmail(dot)com> |
|---|---|
| To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, Yura Sokolov <y(dot)sokolov(at)postgrespro(dot)ru> |
| Subject: | Re: [PoC] Improve dead tuple storage for lazy vacuum |
| Date: | 2024-03-06 08:33:44 |
| Message-ID: | CANWCAZbBcswsNr22aoEHy8AiPN7YRbtgtb74UEJVtG=xPUHX8g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Mar 6, 2024 at 3:02 PM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
>
> ../../src/include/port/simd.h:326:71: error: incompatible type for
> argument 1 of \342\200\230vshrq_n_s8\342\200\231
> uint8x16_t masked = vandq_u8(vld1q_u8(mask), (uint8x16_t) vshrq_n_s8(v, 7));
> ^
>
> Since 'v' is uint8x16_t I think we should have used vshrq_n_u8() instead.
I've looked around and it seems clang is more lax on conversions.
Since it works fine for clang, I think we just need a cast here for
gcc. I've attached a blind attempt at a fix -- I'll apply shortly
unless someone happens to test and find it doesn't work.
| Attachment | Content-Type | Size |
|---|---|---|
| cast-signed-for-gcc.patch | text/x-patch | 556 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2024-03-06 08:40:20 | Re: [PoC] Improve dead tuple storage for lazy vacuum |
| Previous Message | John Naylor | 2024-03-06 08:22:50 | Re: [PoC] Improve dead tuple storage for lazy vacuum |