Re: centralize CPU feature detection

From: John Naylor <johncnaylorls(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, root <tenistarkim(at)gmail(dot)com>, Nathan Bossart <nathandbossart(at)gmail(dot)com>
Subject: Re: centralize CPU feature detection
Date: 2026-02-25 02:15:20
Message-ID: CANWCAZa8ffe+moS=VeDVUZ9EyPxz_dBqCFpddQrK+dqMkg4=hg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Feb 25, 2026 at 2:59 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> It appears that if you want to build pg_cpu_x86.o unconditionally,
> you need to make it more proof against the cases it wasn't getting
> built in before.

Thanks, I must have stopped watching the buildfarm too early. I've
pushed a fix which will get undone as part of v6-0002.

On Wed, Feb 25, 2026 at 2:57 AM Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> wrote:
>
> 2 and 3 looks good too, I only found two more typos:
>
>
> + return pg_comp_crc32c(crc, data, len);
> +};
>
> That semicolon is not needed
>
>
> And in the commit message:
>
> "it has been intialized and if"
>
> That should be initialized

Also fixed, thanks.

--
John Naylor
Amazon Web Services

Attachment Content-Type Size
v6-0002-Centralize-detection-of-x86-CPU-features.patch text/x-patch 11.0 KB
v6-0003-Refactor-detection-of-x86-ZMM-registers.patch text/x-patch 2.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Richard Guo 2026-02-25 02:26:29 Re: Wrong results with grouping sets
Previous Message Andrew Dunstan 2026-02-25 02:06:57 Re: pgsql: libpq: Grease the protocol by default