Re: Duplicated LSN in ReorderBuffer

From: Simon Riggs <simon(at)2ndquadrant(dot)com>
To: Petr Jelinek <petr(at)2ndquadrant(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Ildar Musin <ildar(at)adjust(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Duplicated LSN in ReorderBuffer
Date: 2019-07-29 05:52:48
Message-ID: CANP8+jJtaWhApppJpFsZRqkhpvYa1M5kqSrQCCwNaFKuu-uv0Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, 29 Jul 2019 at 00:09, Petr Jelinek <petr(at)2ndquadrant(dot)com> wrote:

> Given that we don't process any other records in this function besides
> XLOG_HEAP2_MULTI_INSERT and XLOG_HEAP2_NEW_CID, it seems like simplest
> fix is to just remove the first check for fast forward and keep the one
> in XLOG_HEAP2_MULTI_INSERT.
>

Fix proposed by Petr, with comments as explained by Andres.

--
Simon Riggs http://www.2ndQuadrant.com/
<http://www.2ndquadrant.com/>
PostgreSQL Solutions for the Enterprise

Attachment Content-Type Size
allow_XLOG_HEAP2_NEW_CID_while_building_snapshot.v1.patch application/octet-stream 1.2 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro Horiguchi 2019-07-29 05:55:48 Re: psql - add SHOW_ALL_RESULTS option
Previous Message Peter Eisentraut 2019-07-29 05:34:39 Re: how to run encoding-dependent tests by default