Re: [PATCH] PGSERVICEFILE as part of a normal connection string

On Wed, Jun 4, 2025 at 1:42 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Sun, Jun 01, 2025 at 09:36:08PM +0900, Ryo Kanbayashi wrote:
> > Strictly speaking, in a Windows environment, a path containing a
> > backslash is stored in the $td variable, so the value of the
> > $srvfile_valid variable, which contains that path, also needs to be
> > converted.
> > If conversion is not performed, this test will not work correctly in a
> > Windows environment.
> > And just because a path string is included does not necessarily mean
> > that conversion is necessary.
> >
> > But it's difficult to describe this succinctly...
>
> +# Backslashes escaped path string for getting collect result at concatenation
> +# for Windows environment
>
> I could suggest a simpler sentence here:
> "Use correct escaped path for Windows."

OK.
Thanks for suggestion!

> Worth noting a few things reported by a `git diff --check`.

OK.

> +char *
> +PQserviceFile(const PGconn *conn)
>
> All these APIs are public and need to be documented.

OK.

> Another thing that could be added on top of the rest is a psql
> variable called SERVICEFILE, and we would be rather feature complete,
> with:
> - Support in SyncVariables(), as in psql/command.c.

OK.

> - Some documentation as well for the new psql variable, mapping with
> the existing SERVICE.

OK.

> - Perhaps a shortcut for PROMPT?

I will kindly take a rain check on this one :)

> - Use of your new libpq API PQserviceFile().

OK.

> This could be a patch built on top of the introduction of the core API
> for the service file.

:)

---
Great regards,
Ryo Kanbayashi