| From: | Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | Greg Burd <greg(at)burd(dot)me>, KAZAR Ayoub <ma_kazar(at)esi(dot)dz>, Neil Conway <neil(dot)conway(at)gmail(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Shinya Kato <shinya11(dot)kato(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Speed up COPY FROM text/CSV parsing using SIMD |
| Date: | 2026-09-09 10:00:46 |
| Message-ID: | CAN55FZ32XHFj_NuLOY=44Nvj69QJKO_ge6Hhx_WzndSXyreMkg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Tue, 8 Sept 2026 at 18:25, Nathan Bossart <nathandbossart(at)gmail(dot)com> wrote:
>
> On Tue, Sep 08, 2026 at 01:11:00PM +0300, Nazir Bilal Yavuz wrote:
> > Here is an attempt to solve this problem. I ran Manni's script and saw
> > a 1-2% slowdown on TEXT-wide inputs. It is still faster compared to
> > the version without the SIMD patch; the slowdown is relative to the
> > current master branch (which includes the SIMD patch).
>
> Thanks for reporting. Fable 5.1 suggests moving the check to
> CopyLoadInputBuf() to avoid this small regression, which makes sense to me.
> I've attached a new patch that does that. This is definitely a bit of
> hack, and I'm assuming we'll need to revisit this if we want to re-attempt
> more sophisticated heuristics for when to use the SIMD path. But IMHO this
> is self-contained enough to be reasonable for v19.
Thanks for v2; I agree that it is better. I confirm that it solves the
problem and doesn't cause the 1-2% regression I mentioned.
--
Regards,
Nazir Bilal Yavuz
Microsoft
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jim Jones | 2026-09-09 10:01:26 | Re: [PATCH] Allow bare library names for non-superuser LOAD |
| Previous Message | wenhui qiu | 2026-09-09 09:49:51 | Do we reduce autovacuum_naptime max values |