| From: | Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: meson: Optionally disable installation of test modules |
| Date: | 2023-02-23 18:06:26 |
| Message-ID: | CAN55FZ2EmdmfBKnP3hqpkaFhEqJ-5B=c6cQ8M-1i86gf5+2vrQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
Thanks for the review.
On Mon, 20 Feb 2023 at 21:44, Peter Eisentraut
<peter(dot)eisentraut(at)enterprisedb(dot)com> wrote:
>
> I tested this a bit. It works fine. The approach makes sense to me.
>
> The install_additional_files script could be simplified a bit. You
> could use os.makedirs(dest, exist_ok=True) and avoid the error checking.
> I don't think any callers try to copy a directory source, so the
> shutil.copytree() stuff isn't necessary. Run pycodestyle over the
> script. And let's put the script into src/tools/ like the other support
> scripts.
>
I updated the patch in line with your comments.
Regards,
Nazir Bilal Yavuz
Microsoft
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-meson-prevent-installation-of-test-files-during-m.patch | text/x-diff | 26.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Maciek Sakrejda | 2023-02-23 18:15:54 | Re: Proposal: %T Prompt parameter for psql for current time (like Oracle has) |
| Previous Message | Nikolay Samokhvalov | 2023-02-23 17:55:02 | Re: Proposal: %T Prompt parameter for psql for current time (like Oracle has) |