Re: Use streaming read I/O when enabling data checksums online

Hi,

On Mon, 24 Aug 2026 at 15:32, Andrey Borodin <x4mmm(at)yandex-team(dot)ru> wrote:
>
> Hi ChangAo, Daniel, Enrique,
>
> On Mon, Jul 13, 2026 at 9:50 AM Daniel Gustafsson wrote:
> > Thanks for this work, I have it on my radar to review and commit for v20,
> > but will wait for the work of cleaning up and fixing the online checksums
> > code which is currrently ongoing for the beta period.
>
> I read v2 against the current online-checksum code and the earlier design
> thread. I did not find a correctness problem in the conversion.

I wanted to point out a couple of things. I am not sure whether either
is a problem, but I think they are worth mentioning. Before this
patch, an abort caused the function to return immediately after
processing the current buffer. With the read stream, read_stream_end()
stops further look-ahead, but still waits for and releases buffers
already queued by the stream.

1. Performance point. I don't think this is a problem since there
won't be many buffers.

2. Could this cause an error from reading a block that would not
otherwise have been read because of the abort?

--
Regards,
Nazir Bilal Yavuz
Microsoft