From: | Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> |
---|---|
To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Remove unnecessary 'always:' from CompilerWarnings task |
Date: | 2023-11-09 07:53:13 |
Message-ID: | CAN55FZ0of+tDpz5o-tA+bJ9ribjXj7gi6MTm5QP2McRfv4X2rg@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
Thanks for the review.
On Wed, 8 Nov 2023 at 10:31, Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
>
> On 05.09.23 12:25, Nazir Bilal Yavuz wrote:
> > There are multiple 'always:' keywords under the CompilerWarnings task.
> > Instead of that, we can use one 'always:' and move the instructions
> > under this. So, I removed unnecessary ones and rearranged indents
> > according to that change.
>
> I'm not sure this change is beneficial. The way the code is currently
> arranged, it's a bit easier to move or change individual blocks, and
> it's also easier to read the file, because the "always:" is next to each
> "script" and doesn't scroll off the screen.
That makes sense. I am planning to withdraw this soon if there are no
other objections.
Regards,
Nazir Bilal Yavuz
Microsoft
From | Date | Subject | |
---|---|---|---|
Next Message | Hayato Kuroda (Fujitsu) | 2023-11-09 08:20:40 | RE: A recent message added to pg_upgade |
Previous Message | Michael Paquier | 2023-11-09 07:52:32 | Re: A recent message added to pg_upgade |