| From: | Sami Imseih <samimseih(dot)pg(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Bertrand Drouvot <bertranddrouvot(dot)pg(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Lukas Fittl <lukas(at)fittl(dot)com> |
| Subject: | Re: pgstat: Flush some statistics within running transactions, take 2 |
| Date: | 2026-09-05 22:09:57 |
| Message-ID: | CAN12+YLRx-aQnY32YtjyXmGLEbHXd2SmU-auC_fXYCRJoNpRDg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> I have begun processing the refactoring of 0001, where the counters
> are split into two sub-structures, and there was one thing that stood
> out: the test is useful on its own. In pgstat_relation_flush_cb(), I
> have removed the reset of the live/dead counters, then ran the
> main regression test suite to note that nothing fails, except this
> test. The code path is taken, but nothing is exposed in the view to
> show a diff.
>
> In short, extracted this part and applied it after some edits. The
> DROP of table trunc_stats_test5 should have been in 0001, not 0002.
Thanks Michael!
attached is the rebase.
--
Sami Imseih
Amazon Web Services (AWS)
| Attachment | Content-Type | Size |
|---|---|---|
| v13-0001-pgstat-Split-table-stat-counters-into-transactio.patch | application/octet-stream | 22.1 KB |
| v13-0002-pgstat-Allow-pg_stat_force_next_flush-to-work-in.patch | application/octet-stream | 101.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jim Jones | 2026-09-05 22:56:25 | Add require_wal_receiver connection parameter to libpq |
| Previous Message | shihao zhong | 2026-09-05 20:12:49 | Re: [PATCH] pg_surgery: check the page header and line pointers |