| From: | Nikita Malakhov <hukutoc(at)gmail(dot)com> |
|---|---|
| To: | Greg Stark <stark(at)mit(dot)edu> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Teodor Sigaev <teodor(at)sigaev(dot)ru>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Pluggable toaster |
| Date: | 2022-04-01 14:11:16 |
| Message-ID: | CAN-LCVOA9y8enbxfci9O28TeETARBrrnuu0aBowS=MSBMJnWaA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
Have found code corrupted by merge went unnoticed in dummy_toaster.c.
Please look at the attached patches. They must be applied sequentially, one
after another,
from the 1st one. I haven't seed any warnings during compilation (with gcc
on Ubuntu 20),
and check-world goes with no errors.
On Thu, Mar 31, 2022 at 11:15 PM Greg Stark <stark(at)mit(dot)edu> wrote:
> It looks like it's still not actually building on some compilers. I
> see a bunch of warnings as well as an error:
>
> [03:53:24.660] dummy_toaster.c:97:2: error: void function
> 'dummyDelete' should not return a value [-Wreturn-type]
>
> Also the "publication" regression test needs to be adjusted as it
> includes \d+ output which has changed to include the toaster.
>
--
Regards,
Nikita Malakhov
Postgres Professional
https://postgrespro.ru/
| Attachment | Content-Type | Size |
|---|---|---|
| 1_toaster_interface_v3.patch.gz | application/x-gzip | 70.0 KB |
| 2_toaster_default_v3.patch.gz | application/x-gzip | 27.3 KB |
| 3_toaster_snapshot_v3.patch.gz | application/x-gzip | 7.8 KB |
| 4_bytea_appendable_toaster_v3.patch.gz | application/x-gzip | 19.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2022-04-01 14:24:48 | Re: Use "WAL segment" instead of "log segment" consistently in user-facing messages |
| Previous Message | James Coleman | 2022-04-01 14:10:36 | Re: Restructure ALTER TABLE notes to clarify table rewrites and verification scans |