Re: bug fix and documentation improvement about vacuumdb

From: Kuwamura Masaki <kuwamura(at)db(dot)is(dot)i(dot)nagoya-u(dot)ac(dot)jp>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: Nathan Bossart <nathandbossart(at)gmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: bug fix and documentation improvement about vacuumdb
Date: 2023-09-21 01:53:09
Message-ID: CAMyC8qqJzCGdz9sCLaNUpCy1baQrnTT=Orinvx-GfYwrz8LFhQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

>
> I agree. Supporting pattern matching should, if anyone is interested in
> trying, be done separately in its own thread, no need to move the goalposts
> here. Sorry if I made it sound like so upthread.
>
I got it.

> When sending an update, please include the previous patch as well with
> your new
> tests as a 0002 patch in a patchset. The CFBot can only apply and
> build/test
> patches when the entire patchset is attached to the email. The below
> testresults indicate that the patch failed the new tests (which in a way is
> good since without the fix the tests *should* fail), since the fix patch
> was
> not applied:
>
> http://cfbot.cputube.org/masaki-kuwamura.html
>
I'm sorry, I didn't know that. I attached both the test and fix patch to
this mail.
(The fix patch is clearly Nathan-san's though)
If I'm still in a wrong way, please let me know.

Masaki Kuwamura

Attachment Content-Type Size
v1_vacuumdb_add_tests.patch application/octet-stream 1.8 KB
vacuumdb_fix.patch application/octet-stream 1.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message bt23nguyent 2023-09-21 02:18:00 Re: Improve the log message output of basic_archive when basic_archive.archive_directory parameter is not set
Previous Message Ryoga Yoshida 2023-09-21 01:44:49 Bug fix in vacuumdb --buffer-usage-limit xxx -Z