| From: | Soumya S Murali <soumyamurali(dot)work(at)gmail(dot)com> |
|---|---|
| To: | Oleg Tselebrovskiy <o(dot)tselebrovskiy(at)postgrespro(dot)ru> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: 001_password.pl fails with --without-readline |
| Date: | 2026-01-02 10:09:40 |
| Message-ID: | CAMtXxw_kvxZPMnUu5dgTyVwRhwgaFDXAMW4UwhOuUURKHT6U1Q@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
I reapplied the patch and tested the patch with (enable-tap-tests +
readline and enable-tap-tests + without-readline). I think the issue
was caused by differences in how psql emits prompts and echoed output
without readline which could lead to banner interleaving, timeouts or
premature TAP termination. In my patch I included the fixes that make
banner detection in BackgroundPsql.pm to be tolerant while keeping
strict line-based cleanup to preserve correct TAP behavior. The fix is
behavior-based and does not rely on configuration variables or test
skipping.
Kindly review my patch attached herewith and please let me know the feedback.
Regards
Soumya
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Fix-authentication-test-failure-with-or-without-read.patch | text/x-patch | 2.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dharin Shah | 2026-01-02 11:38:25 | Re: [PATCH][DOC][MINOR] Fix incorrect lexeme limit in textsearch docs |
| Previous Message | Andrey Borodin | 2026-01-02 09:25:10 | Re: CREATE TABLE LIKE INCLUDING TRIGGERS |