Re: Logical decoding on standby

From: Craig Ringer <craig(at)2ndquadrant(dot)com>
To: Simon Riggs <simon(dot)riggs(at)2ndquadrant(dot)com>
Cc: Thom Brown <thom(at)linux(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Logical decoding on standby
Date: 2017-03-20 09:31:53
Message-ID: CAMsr+YHuGRgE3K7FRFJMUk7KfehNLfj=qV4=U8Q2q6hDO=ftqQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On 20 March 2017 at 17:03, Craig Ringer <craig(at)2ndquadrant(dot)com> wrote:
> On 20 March 2017 at 14:57, Simon Riggs <simon(dot)riggs(at)2ndquadrant(dot)com> wrote:
>
>> 2.1 Why does call to ReplicationSlotAcquire() move earlier in
>> pg_logical_slot_get_changes_guts()?
>
> That appears to be an oversight from an earlier version where it
> looped over timelines in pg_logical_slot_get_changes_guts . Reverted.
>
>> 2.2 sendTimeLineIsHistoric looks incorrect, and at least isn't really
>> documented well.
>> The setting
>> sendTimeLineIsHistoric = state->currTLI == ThisTimeLineID;
>> should be
>> sendTimeLineIsHistoric = (state->currTLI != ThisTimeLineID);
>
> Definitely wrong. Fixed.

Attached.

--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

Attachment Content-Type Size
0001-Follow-timeline-switches-in-logical-decoding.patch text/x-patch 20.7 KB
0002-Logical-decoding-on-standby.patch text/x-patch 102.5 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexander Korotkov 2017-03-20 09:33:26 Re: [PATCH] Incremental sort (was: PoC: Partial sort)
Previous Message Petr Jelinek 2017-03-20 09:29:44 Re: logical decoding of two-phase transactions