Re: WIP: Failover Slots

From: Craig Ringer <craig(at)2ndquadrant(dot)com>
To: Oleksii Kliukin <alexk(at)hintbits(dot)com>
Cc: Petr Jelinek <petr(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>
Subject: Re: WIP: Failover Slots
Date: 2016-03-15 13:40:59
Message-ID: CAMsr+YHcAHoWKSnWQdYSWDsLZNpmP3BFHr4n7_hEwv4g1T7j8g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Here's a new failover slots rev, addressing the issues Oleksii Kliukin
raised and adding a bunch of TAP tests.

In particular, for the checkpoint issue I landed up moving
CheckPointReplicationSlots to occur at the start of a checkpoint, before
writing WAL is prohibited. As the comments note it's just a convenient
place and time to do it anyway. That means it has to be called separately
at a restartpoint, but I don't think that's a biggie.

The tests for this took me quite a while, much (much) longer than the code
changes.

I split the patch up a bit more too so individual changes are more
logically grouped and clearer. I expect it'd be mostly or entirely squashed
for commit.

Attachment Content-Type Size
0001-Allow-replication-slots-to-follow-failover.patch text/x-patch 47.0 KB
0002-Update-decoding_failover-tests-for-failover-slots.patch text/x-patch 3.2 KB
0003-Retain-extra-WAL-for-failover-slots-in-base-backups.patch text/x-patch 3.6 KB
0004-Add-the-UI-and-for-failover-slots.patch text/x-patch 11.7 KB
0005-Document-failover-slots.patch text/x-patch 8.4 KB
0006-Add-failover-to-pg_replication_slots.patch text/x-patch 9.6 KB
0007-Introduce-TAP-recovery-tests-for-failover-slots.patch text/x-patch 14.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fabien COELHO 2016-03-15 13:55:52 Re: pgbench - allow backslash-continuations in custom scripts
Previous Message David Rowley 2016-03-15 13:40:15 Re: Parallel Aggregate