Re: Logical decoding on standby

From: Craig Ringer <craig(at)2ndquadrant(dot)com>
To: Thom Brown <thom(at)linux(dot)com>
Cc: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Simon Riggs <simon(dot)riggs(at)2ndquadrant(dot)com>
Subject: Re: Logical decoding on standby
Date: 2017-01-23 22:37:05
Message-ID: CAMsr+YEN04ztb+SDb_UfD72Kg5M3F+Cpad31QBKT2rRjysmxRg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

Rebased series attached, on top of current master (which includes
logical replicaiton).

I'm inclined to think I should split out a few of the changes from
0005, roughly along the lines of the bullet points in its commit
message. Anyone feel strongly about how granular this should be?

This patch series is a pre-requisite for supporting logical
replication using a physical standby as a source, but does not its
self enable logical replication from a physical standby.

On 23 January 2017 at 23:03, Thom Brown <thom(at)linux(dot)com> wrote:
> On 5 January 2017 at 01:21, Craig Ringer <craig(at)2ndquadrant(dot)com> wrote:
>> On 5 January 2017 at 09:19, Craig Ringer <craig(at)2ndquadrant(dot)com> wrote:
>>
>>> so here's a rebased series on top of master. No other changes.
>>
>> Now with actual patches.
>
> Patch 5 no longer applies:
>
> patching file src/include/pgstat.h
> Hunk #1 FAILED at 745.
> 1 out of 1 hunk FAILED -- saving rejects to file src/include/pgstat.h.rej
>
> --- src/include/pgstat.h
> +++ src/include/pgstat.h
> @@ -745,7 +745,8 @@ typedef enum
> WAIT_EVENT_SYSLOGGER_MAIN,
> WAIT_EVENT_WAL_RECEIVER_MAIN,
> WAIT_EVENT_WAL_SENDER_MAIN,
> - WAIT_EVENT_WAL_WRITER_MAIN
> + WAIT_EVENT_WAL_WRITER_MAIN,
> + WAIT_EVENT_STANDBY_LOGICAL_SLOT_CREATE
> } WaitEventActivity;
>
> /* ----------
>
> Could you rebase?
>
> Thanks
>
> Thom

--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

Attachment Content-Type Size
0001-Add-a-pg_recvlogical-wrapper-to-PostgresNode.patch text/x-patch 5.6 KB
0002-Follow-timeline-switches-in-logical-decoding.patch text/x-patch 20.9 KB
0003-Make-snapshot-export-on-logical-slot-creation-option.patch text/x-patch 8.3 KB
0004-ERROR-if-timeline-is-zero-in-walsender.patch text/x-patch 938 bytes
0005-Logical-decoding-on-standby.patch text/x-patch 100.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jim Nasby 2017-01-23 22:54:36 Re: Protect syscache from bloating with negative cache entries
Previous Message David Steele 2017-01-23 22:22:34 Re: patch proposal