| From: | Nitin Jadhav <nitinjadhavpostgres(at)gmail(dot)com> |
|---|---|
| To: | surya poondla <suryapoondla4(at)gmail(dot)com> |
| Cc: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Reporting WAL replay progress during pre-consistency standby reovery |
| Date: | 2026-11-09 05:10:16 |
| Message-ID: | CAMm1aWaV6CtZV0yAWaCM5NiWPkJKfmy4r4+vbfdDQn17v_xbaA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> v1 applies cleanly to current master and builds without warnings.
>
> I think this is worth having and have a few comments:
Thanks for supporting the proposal, reviewing the patch, and catching
these issues. I appreciate the detailed analysis and testing.
I have attached v2 with both changes. I restored the unconditional
disable_startup_progress_timeout() call in EnableStandbyMode() and
removed the log_startup_progress_interval == 0 check from
disable_startup_progress_timeout().
I also tested reloading the interval from one second to zero during
pre-consistency replay and confirmed that the timer stops firing after
consistency.
Please review the v2 patch and let me know if you have any other comments.
Best Regards,
Nitin Jadhav
Microsoft
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Report-standby-replay-progress-before-consistency.patch | application/octet-stream | 3.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2026-11-09 05:11:37 | Re: Wrong results with initplans moved by setrefs.c |
| Previous Message | Xuneng Zhou | 2026-11-09 04:51:28 | Re: BGWORKER_INTERRUPTIBLE workers are never restarted after DROP/ALTER/CREATE DATABASE |