add verbosity to pg_basebackup for sync

From: Jeff Janes <jeff(dot)janes(at)gmail(dot)com>
To: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: add verbosity to pg_basebackup for sync
Date: 2018-07-27 15:58:42
Message-ID: CAMkU=1ypeoMJ=tFBG8vP13sxEtXd4Pm_x1SqsJdW_RvzpcvN=A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On some recent testing, pg_basebackup -Fp was taking an annoying amount of
time to finish once the it was done copying the data. Using -v seemed to
blame this on "waiting for background process to finish streaming", based
on that being the last message on display while the delay was happening.

But it was really waiting for the syncs of the new -D dir to finish. The
attached patch adds a -v notice that it is starting to do the sync, with
the wording taken from initdb's equivalent message.

I think -P should report everything -v does, just with a carriage return
rather than a newline, but that is a larger issue.

Cheers,

Jeff

Attachment Content-Type Size
pg_basebackup_v_sync.patch application/octet-stream 425 bytes

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2018-07-27 15:59:12 Re: How can we submit code patches that implement our (pending) patents?
Previous Message Stephen Frost 2018-07-27 15:29:37 Re: Auditing via logical decoding