| From: | Richard Guo <guofenglinux(at)gmail(dot)com> |
|---|---|
| To: | James Coleman <jtc331(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: An inefficient query caused by unnecessary PlaceHolderVar |
| Date: | 2023-07-18 07:17:15 |
| Message-ID: | CAMbWs4_eirXvzoCvbQCLKMH=KZfmiLQ7pxG5RaiX6d73PobMJA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jun 2, 2023 at 1:33 AM James Coleman <jtc331(at)gmail(dot)com> wrote:
> On Wed, May 31, 2023 at 10:30 PM Richard Guo <guofenglinux(at)gmail(dot)com>
> wrote:
> > Thanks for the review!
>
> Sure thing!
I've updated the patch according to the reviews as attached. But I did
not add ORDER BY clause in the test, as we don't need it for correctness
for this test query and the surrounding queries in join.sql don't have
ORDER BY either.
Thanks
Richard
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Avoid-unnecessary-PlaceHolderVars-for-simple-Vars.patch | application/octet-stream | 14.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2023-07-18 07:26:35 | Re: generic plans and "initial" pruning |
| Previous Message | Zhijie Hou (Fujitsu) | 2023-07-18 07:09:23 | RE: Support logical replication of DDLs |