| From: | Richard Guo <guofenglinux(at)gmail(dot)com> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | Julien Rouhaud <rjuju123(at)gmail(dot)com>, 謝東霖 <douenergy(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Improve join_search_one_level readibilty (one line change) |
| Date: | 2023-08-04 04:05:14 |
| Message-ID: | CAMbWs4_QKD4tNn6mmY7-u-HrzHcN4PM8-ope8vYtmpDkOuGXGQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Aug 4, 2023 at 10:36 AM David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> The whole lnext() stuff all feels a bit old now that Lists are arrays.
> I think we'd be better adjusting the code to pass the List index where
> we start from rather than the ListCell to start from. That way we can
> use for_each_from() to iterate rather than for_each_cell(). What's
> there today feels a bit crufty and there's some element of danger that
> the given ListCell does not even belong to the given List.
I think we can go even further to do the same for 'bushy plans' case,
like the attached.
Thanks
Richard
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-join_search_one_level-tidyup.patch | application/octet-stream | 4.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andy Fan | 2023-08-04 04:38:23 | Re: Extract numeric filed in JSONB more effectively |
| Previous Message | Yugo NAGATA | 2023-08-04 04:03:25 | pgbench: allow to exit immediately when any client is aborted |