Re: Check lateral references within PHVs for memoize cache keys

From: Richard Guo <guofenglinux(at)gmail(dot)com>
To: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Check lateral references within PHVs for memoize cache keys
Date: 2023-07-04 07:33:22
Message-ID: CAMbWs4_E2HcTJ0b2srM3hwnQbH5SogkZMM399WUG4gTQSa1FOQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Dec 30, 2022 at 11:00 AM Richard Guo <guofenglinux(at)gmail(dot)com> wrote:

> On Fri, Dec 9, 2022 at 5:16 PM Richard Guo <guofenglinux(at)gmail(dot)com> wrote:
>
>> Actually we do have checked PHVs for lateral references, earlier in
>> create_lateral_join_info. But that time we only marked lateral_relids
>> and direct_lateral_relids, without remembering the lateral expressions.
>> So I'm wondering whether we can fix that by fetching Vars (or PHVs) of
>> lateral references within PlaceHolderVars and remembering them in the
>> baserel's lateral_vars.
>>
>> Attach a draft patch to show my thoughts.
>>
>
> Update the patch to fix test failures.
>

Rebase the patch on HEAD as cfbot reminds.

Thanks
Richard

Attachment Content-Type Size
v3-0001-Check-lateral-refs-within-PHVs-for-memoize-cache-keys.patch application/octet-stream 7.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Drouvot, Bertrand 2023-07-04 07:34:33 Re: Autogenerate some wait events code and documentation
Previous Message Daniel Gustafsson 2023-07-04 07:30:43 Re: O(n) tasks cause lengthy startups and checkpoints