Re: Memoize ANTI and SEMI JOIN inner

From: Richard Guo <guofenglinux(at)gmail(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: David Rowley <dgrowleyml(at)gmail(dot)com>, Andrei Lepikhov <lepihov(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Memoize ANTI and SEMI JOIN inner
Date: 2025-05-14 02:13:56
Message-ID: CAMbWs48g0Q_mWJip_dDEcgaCHZw71MRB=pkz4B6PzWyfVWWaCA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, May 13, 2025 at 10:51 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
> This is failing on CI:
> https://cirrus-ci.com/github/postgresql-cfbot/postgresql/cf%2F5636
> https://api.cirrus-ci.com/v1/artifact/task/5411026402803712/testrun/build-32/testrun/regress/regress/regression.diffs
>
> diff -U3 /tmp/cirrus-ci-build/src/test/regress/expected/memoize.out /tmp/cirrus-ci-build/build-32/testrun/regress/regress/results/memoize.out
> --- /tmp/cirrus-ci-build/src/test/regress/expected/memoize.out 2025-04-12 11:24:10.866868945 +0000
> +++ /tmp/cirrus-ci-build/build-32/testrun/regress/regress/results/memoize.out 2025-04-12 11:32:44.454864476 +0000
> @@ -525,7 +525,7 @@
> -> Unique (actual rows=2.67 loops=N)
> -> Sort (actual rows=67.33 loops=N)
> Sort Key: t2_1.a
> - Sort Method: quicksort Memory: 27kB
> + Sort Method: quicksort Memory: 18kB
> -> Seq Scan on tab_anti t2_1 (actual rows=100.00 loops=N)
> (15 rows)
>
>
> There shouldn't be Memory mentioned in tests added to the tree.

Thanks for pointing this out. You're right — Memory usage should be
hidden from the output of EXPLAIN ANALYZE. I'm a bit surprised the
existing explain_memoize function doesn't already handle that; I
guess it's because the plans in memoize.sql don't currently include
any Sort nodes. In any case, I've added a regexp_replace to filter
out 'Memory: \d+kB' in explain_memoize.

Thanks
Richard

Attachment Content-Type Size
v2-0001-Enable-use-of-Memoize-for-ANTI-joins.patch application/octet-stream 9.8 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message David E. Wheeler 2025-05-14 03:00:34 Re: PATCH: jsonpath string methods: lower, upper, initcap, l/r/btrim, replace, split_part
Previous Message Richard Guo 2025-05-14 01:05:51 Re: Add explicit initialization for all PlannerGlobal fields