| From: | Richard Guo <guofenglinux(at)gmail(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Andy Fan <zhihui(dot)fan1213(at)gmail(dot)com>, Aleksander Alekseev <aleksander(at)timescale(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: A minor adjustment to get_cheapest_path_for_pathkeys |
| Date: | 2023-09-07 02:21:31 |
| Message-ID: | CAMbWs48_1wSeHZrpBRrnaSGg5V9R_Tg5f3Q-+-NEE6WLNE6zng@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Sep 6, 2023 at 8:50 PM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Wed, Sep 6, 2023 at 2:45 AM Andy Fan <zhihui(dot)fan1213(at)gmail(dot)com> wrote:
> > In my opinion, we can do some stuff to improve the ROI.
> > - Authors should do as much as possible, mainly a better commit
> > message. As for this patch, the commit message is " Adjustment
> > to get_cheapest_path_for_pathkeys" which I don't think matches
> > our culture.
>
> I agree. I don't think the patch submitter is obliged to try to write
> a good commit message, but people who contribute regularly or are
> posting large stacks of complex patches are probably well-advised to
> try. It makes life easier for committers and even for reviewers trying
> to make sense of their patches.
Fair point. So I had a go at writing a commit message for this patch as
attached. Thanks for all the reviews.
Thanks
Richard
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Reorder-the-tests-in-get_cheapest_path_for_pathkeys.patch | application/octet-stream | 2.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2023-09-07 02:41:08 | Re: A failure in 031_recovery_conflict.pl on Debian/s390x |
| Previous Message | Peter Smith | 2023-09-07 00:36:29 | Re: Add 'worker_type' to pg_stat_subscription |