| From: | Richard Guo <guofenglinux(at)gmail(dot)com> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, william(dot)duclot(at)gmail(dot)com, PostgreSQL mailing lists <pgsql-bugs(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: BUG #17540: Prepared statement: PG switches to a generic query plan which is consistently much slower |
| Date: | 2023-07-10 06:39:27 |
| Message-ID: | CAMbWs4-cWwe0whACTuKTLT+4jNcSJ+RLEcSp4us1vBAt0k7GAA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
On Mon, Jul 10, 2023 at 10:14 AM David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> On Fri, 7 Jul 2023 at 19:03, Richard Guo <guofenglinux(at)gmail(dot)com> wrote:
> > Attached is what I have in mind. The patch extends the logic from two
> > points.
> >
> > * it also checks OR clauses to see if it is always true.
> >
> > * it also checks for join clauses by additionally testing if the nulling
> > bitmap is empty.
>
> Do you mind writing some regression tests for this?
>
> I don't really see an existing test file that would suit, maybe it's
> worth adding something like predicate.sql
Here is v3 patch with regression tests. I add the new test into the
group where stats test is in, but I'm not sure if this is the right
place.
Thanks
Richard
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-ignore-is-not-null-quals-on-not-null-columns.patch | application/octet-stream | 16.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Vamshikrishna T | 2023-07-10 11:27:27 | Re: BUG #18009: Postgres Recovery not happening |
| Previous Message | David Rowley | 2023-07-10 02:14:04 | Re: BUG #17540: Prepared statement: PG switches to a generic query plan which is consistently much slower |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2023-07-10 06:43:07 | Re: Should we remove db_user_namespace? |
| Previous Message | Kyotaro Horiguchi | 2023-07-10 06:27:37 | Re: Standardize type of variable when extending Buffers |