| From: | Hannu Krosing <hannuk(at)google(dot)com> |
|---|---|
| To: | Robert Treat <rob(at)xzilla(dot)net> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pgbench - adding pl/pgsql versions of tests |
| Date: | 2026-01-11 11:08:46 |
| Message-ID: | CAMT0RQSaFpzk2DZM0jZeiYmHm2sd9fetCKXSUBGYG7_4V-DqMA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Sep 1, 2025 at 3:28 PM Robert Treat <rob(at)xzilla(dot)net> wrote:
> Hey Hannu,
>
> I took the above for a spin and generally it all worked well and I do
> think it is a nice addition.
> Attached v4 patch basically combines v3
> 01 and 02 patches into one (you need both or the build fails on the
> docs, so...), along with the following changes:
> - whitespace and typo fixes in pgbench.c
> - wordsmithing the caution notification, clean up --no-functions doc
> - document the new Yy options alongside other -I options.
Thanks, very useful.
> On that last item, I did notice that there is a potential backwards
> compatibility issue, which is that existing scripts that are reliant
> on functions existing will need to be updated to include "y", but that
> feels pretty niche, so I am not personally worried about it.
As the functions are a new addition anyway I am also not worried.
Here is a rebased version, only change is in the flag id for --no-functions
---
Hannu
| Attachment | Content-Type | Size |
|---|---|---|
| v5-0001-rebased-changed-no-functions-flag-id-from-18-to-19.patch | application/x-patch | 17.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jonathan Gonzalez V. | 2026-01-11 11:20:40 | Add pg_get_publication_ddl function |
| Previous Message | Henson Choi | 2026-01-11 10:53:44 | Re: SQL Property Graph Queries (SQL/PGQ) |