| From: | Doruk Yilmaz <doruk(at)mixrank(dot)com> |
|---|---|
| To: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Subject: | Re: [Patch] add new parameter to pg_replication_origin_session_setup |
| Date: | 2025-08-18 18:55:19 |
| Message-ID: | CAMPB6wdc10tc7gpVXG75r51M41zVSabip9Lz7hssWEtyhecWww@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> Your use looks good to me. So, maybe we can update the docs with the
> dangers if the users of API doesn't follow commit order then it may
> lead to data inconsistency should be sufficient. Additionally, we may
> want to give an example as to how to use this API for parallel apply.
That sounds reasonable. I’ve updated the patch and added more
information to the documentation covering the topics you mentioned.
I also added a Caution block so potential users won’t miss it. I hope
this patch meets your expectations.
| Attachment | Content-Type | Size |
|---|---|---|
| v5-0001-pg_replication_origin_session_setup-pid-parameter.patch | text/x-patch | 5.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | SATYANARAYANA NARLAPURAM | 2025-08-18 18:59:07 | Re: Add CHECK_FOR_INTERRUPTS in pg_buffercache_pages while scanning the buffers |
| Previous Message | Tom Lane | 2025-08-18 18:41:43 | Re: Small issue with kerberos tests |