Re: Auxiliary Processes and MyAuxProc

From: Mike Palmiotto <mike(dot)palmiotto(at)crunchydata(dot)com>
To: Justin Pryzby <pryzby(at)telsasoft(dot)com>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Andres Freund <andres(at)anarazel(dot)de>, Yuli Khodorkovskiy <yuli(dot)khodorkovskiy(at)crunchydata(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Auxiliary Processes and MyAuxProc
Date: 2020-03-18 16:07:03
Message-ID: CAMN686GXRr2nZECF-zP5jz_uC6kxS7wnmNfQMjgf4hQLX6m7fA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Mar 18, 2020 at 11:26 AM Mike Palmiotto
<mike(dot)palmiotto(at)crunchydata(dot)com> wrote:
>
> On Wed, Mar 18, 2020 at 10:17 AM Justin Pryzby <pryzby(at)telsasoft(dot)com> wrote:
> > Also, I saw this was failing tests both before and after my rebase.
> >
> > http://cfbot.cputube.org/
> > https://ci.appveyor.com/project/postgresql-cfbot/postgresql/builds/31535161
> > https://ci.appveyor.com/project/postgresql-cfbot/postgresql/builds/31386446
>
> Good catch, thanks. Will address this as well in the next round. Just
> need to set up a Windows dev environment to see if I can
> reproduce/fix.

While I track this down, here is a rebased patchset, which drops
MySubprocessType and makes use of the MyBackendType.

Once I get the fix for Windows builds, I'll see about making use of
the rmgrlist/cmdtaglist-style technique that Alvaro suggested.

Thanks,
--
Mike Palmiotto
https://crunchydata.com

Attachment Content-Type Size
0001-Add-subprocess-infrastructure.patch text/x-patch 14.3 KB
0002-Use-centralized-StartSubprocess-for-aux-procs.patch text/x-patch 14.9 KB
0003-Add-AutoVacLauncherType-to-subprocess-struct.patch text/x-patch 7.5 KB
0004-Add-AutoVacuumWorkerType-to-subprocess-struct.patch text/x-patch 6.4 KB
0005-Add-PgstatCollectorType-to-subprocess-struct.patch text/x-patch 11.6 KB
0006-Add-PgArchiverType-to-subprocess-struct.patch text/x-patch 7.7 KB
0007-Add-SysLoggerType-to-subprocess-struct.patch text/x-patch 16.9 KB
0008-Add-BgWorkerType-to-subprocess-struct.patch text/x-patch 25.6 KB
0009-Add-Backends-to-subprocess-struct.patch text/x-patch 16.0 KB
0010-Add-WalSenderType-to-subprocess-struct.patch text/x-patch 1.4 KB
0011-Move-to-new-MyBackendType.patch text/x-patch 19.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2020-03-18 16:13:59 Re: pg_stat_progress_basebackup - progress reporting for pg_basebackup, in the server side
Previous Message Tomas Vondra 2020-03-18 15:55:43 Re: PATCH: add support for IN and @> in functional-dependency statistics use