Fixing tab-complete for dollar-names

From: Mikhail Gribkov <youzhick(at)gmail(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Fixing tab-complete for dollar-names
Date: 2023-06-16 21:51:30
Message-ID: CAMEv5_sTAvPvhye+u4jkWDe5UGDiQ1ZkQomnKCboM08zDzOe=g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi hackers,

In modern versions of Postgres the dollar sign is a totally legal character
for identifiers (except for the first character), but tab-complete do not
treat such identifiers well.
For example if one try to create an Oracle-style view like this:

create view v$activity as select * from pg_stat_activity;

, he will get a normally functioning view, but psql tab-complete will not
help him. Type "v", "v$" or "v$act" and press <TAB> - nothing will be
suggested.

Attached is a small patch fixing this problem.
Honestly I'm a little surprised that this was not done before. Maybe, there
are some special considerations I am not aware of, and the patch will break
something?
What would you say?
--
best regards,
Mikhail A. Gribkov

Attachment Content-Type Size
v001_fix_dollar_names_tab_complete.patch application/octet-stream 749 bytes

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeff Davis 2023-06-16 22:03:34 Re: pg_collation.collversion for C.UTF-8
Previous Message Jeff Davis 2023-06-16 21:42:26 Re: [17] collation provider "builtin"