| From: | Peter Geoghegan <pg(at)heroku(dot)com> |
|---|---|
| To: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Minor ON CONFLICT related fixes |
| Date: | 2015-05-12 01:53:22 |
| Message-ID: | CAM3SWZSfqeYMbWvTYxr2J_ymXY+XkPp=s277yREqk7J5_+ccpg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Attached patch fixes some issues with ON CONFLICT DO UPDATE/DO
NOTHING. There is a commit message which explains the changes at a
high level. The only real bug fix is around deparsing by ruleutils.c.
Note that the patch proposes to de-support CREATE RULE with an
alternative action involving ON CONFLICT DO UPDATE. Such a rule seems
particularly questionable to me, and I'm pretty sure it was understood
that only ON CONFLICT DO NOTHING should be supported as an action for
a rule (recall that INSERT statements with ON CONFLICT can, in
general, never target relations with rules). At least, I believe
Heikki said that.
Thoughts?
--
Peter Geoghegan
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Fixes-to-a-variety-of-minor-ON-CONFLICT-issues.patch | text/x-patch | 23.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2015-05-12 02:02:52 | Re: Minor ON CONFLICT related fixes |
| Previous Message | Robert Haas | 2015-05-12 01:50:22 | Re: Multi-xacts and our process problem |