| From: | Peter Geoghegan <pg(at)heroku(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Corey Huinker <corey(dot)huinker(at)gmail(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Should TIDs be typbyval = FLOAT8PASSBYVAL to speed up CREATE INDEX CONCURRENTLY? |
| Date: | 2015-12-12 23:39:39 |
| Message-ID: | CAM3SWZRQuNGdtPFrAMmf5=3RMup2kpbJGJxU24MHswAzwjNrDA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Dec 11, 2015 at 9:13 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> Also, I'd be in favor of you updating the patch to reflect the
> comments from Tom and Simon on November 17th.
Attached revision:
* Has more worked out comments on encoding, per Simon's request.
* Uses Tom's preferred formulation for encoding TIDs (which involves
unsigned integer casts).
* Sets indexcursor = NULL when the tuplesort is empty, just to be
tidy, per Tom's request.
--
Peter Geoghegan
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Speed-up-CREATE-INDEX-CONCURRENTLY-s-TID-sort.patch | text/x-patch | 5.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2015-12-12 23:42:16 | Re: Using a single standalone-backend run in initdb (was Re: Bootstrap DATA is a pita) |
| Previous Message | Tom Lane | 2015-12-12 23:26:57 | Re: Using a single standalone-backend run in initdb (was Re: Bootstrap DATA is a pita) |