Re: Word-smithing doc changes

From: Greg Stark <stark(at)mit(dot)edu>
To: Greg Smith <greg(at)2ndquadrant(dot)com>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, "<pgsql-hackers(at)postgresql(dot)org>" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Word-smithing doc changes
Date: 2011-11-30 18:20:18
Message-ID: CAM-w4HPnN=7QyhdkEOpZ+hBGi4sHGv-N6L+OCvGWEHVqQPUTdg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Nov 30, 2011 at 8:02 AM, Greg Smith <greg(at)2ndquadrant(dot)com> wrote:
>>>> Except in the sections talking about locking
>>>> internals we don't talk about "shared locks on virtual transactions
>>>> identifiers" we just talk about waiting for a transaction to complete.

> What I cannot agree with is that idea that the implementation details I
> suggested documenting should not be.

What I'm suggesting is translating things like "shared locks on
virtual transaction identifiers" into what that means for users.
Namely saying something like "waiting for a transaction to complete".

Given your confusion it's clear that we have to explain that it will
wait one by one for each transaction that was started before the index
was created to finish. I don't think we need to explain how that's
implemented. If we do it should be set aside in some way, something
like "(see virtual transaction id locks in <href...>)".

I just want to keep in mind that the reader here is trying to
understand how to use create index concurrently, not understand how
Postgres's locking infrastructure works in general.

--
greg

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2011-11-30 18:20:35 Re: Why so few built-in range types?
Previous Message Jeff Davis 2011-11-30 18:08:44 Re: Why so few built-in range types?