Re: WIP: Aggregation push-down - take2

From: "Gregory Stark (as CFM)" <stark(dot)cfm(at)gmail(dot)com>
To: Antonin Houska <ah(at)cybertec(dot)at>
Cc: vignesh C <vignesh21(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, "Fujii(dot)Yuki(at)df(dot)MitsubishiElectric(dot)co(dot)jp" <Fujii(dot)Yuki(at)df(dot)mitsubishielectric(dot)co(dot)jp>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "david(at)pgmasters(dot)net" <david(at)pgmasters(dot)net>, "tgl(at)sss(dot)pgh(dot)pa(dot)us" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "zhihui(dot)fan1213(at)gmail(dot)com" <zhihui(dot)fan1213(at)gmail(dot)com>, "legrand_legrand(at)hotmail(dot)com" <legrand_legrand(at)hotmail(dot)com>, "daniel(at)yesql(dot)se" <daniel(at)yesql(dot)se>
Subject: Re: WIP: Aggregation push-down - take2
Date: 2023-03-01 21:06:08
Message-ID: CAM-w4HOVv_9xjZqbL76x0eexrHEkE8dyVTD6-1uPy5R0o-c4EQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, 5 Jan 2023 at 02:59, Antonin Houska <ah(at)cybertec(dot)at> wrote:
>
> vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
> > The patch does not apply on top of HEAD as in [1], please post a rebased patch:

And again...

Setting this to Waiting on Author for the moment.

Do you think this patch is likely to be ready for this release or the
next one? Is there specific feedback you're looking for?

patching file src/backend/optimizer/util/relnode.c
Hunk #1 FAILED at 18.
Hunk #2 succeeded at 85 (offset 8 lines).
Hunk #3 succeeded at 405 with fuzz 1 (offset 25 lines).
Hunk #4 succeeded at 595 (offset 63 lines).
Hunk #5 succeeded at 657 (offset 63 lines).
Hunk #6 succeeded at 692 (offset 63 lines).
Hunk #7 succeeded at 731 (offset 63 lines).
Hunk #8 succeeded at 849 (offset 62 lines).
Hunk #9 succeeded at 860 (offset 62 lines).
Hunk #10 succeeded at 873 (offset 62 lines).
Hunk #11 FAILED at 911.
Hunk #12 FAILED at 945.
Hunk #13 succeeded at 2585 (offset 310 lines).
3 out of 13 hunks FAILED -- saving rejects to file
src/backend/optimizer/util/relnode.c.rej
patching file src/backend/optimizer/util/tlist.c
patching file src/backend/utils/misc/guc_tables.c
Hunk #1 succeeded at 946 (offset 1 line).
patching file src/backend/utils/misc/postgresql.conf.sample
Hunk #1 succeeded at 390 (offset 2 lines).
patching file src/include/nodes/pathnodes.h
Hunk #1 succeeded at 386 (offset 10 lines).
Hunk #2 succeeded at 429 (offset 10 lines).
Hunk #3 succeeded at 477 (offset 38 lines).
Hunk #4 succeeded at 1084 (offset 37 lines).
Hunk #5 succeeded at 3117 (offset 146 lines).
patching file src/include/optimizer/clauses.h
patching file src/include/optimizer/pathnode.h
Hunk #2 FAILED at 311.
Hunk #3 FAILED at 344.
2 out of 3 hunks FAILED -- saving rejects to file
src/include/optimizer/pathnode.h.rej

--
Gregory Stark
As Commitfest Manager

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2023-03-01 21:06:14 Re: Non-superuser subscription owners
Previous Message Gregory Stark (as CFM) 2023-03-01 20:59:23 Re: Operation log for major operations