Re: minor gripe about lax reloptions parsing for views

From: Greg Stark <stark(at)mit(dot)edu>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: minor gripe about lax reloptions parsing for views
Date: 2022-03-31 19:11:00
Message-ID: CAM-w4HO1JqbdL0SvhkjaFR+MyRCbZntiVCOQTniBSDrM7URrOg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

The patch is currently not applying.

And it looks like there hasn't been any discussion since Alvaro's
comments last december. I'm marking the patch Returned with Feedback.

On Fri, 24 Dec 2021 at 16:49, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
>
> On 2021-Dec-21, Mark Dilger wrote:
>
> > Rebased patch attached:
>
> These tests are boringly repetitive. Can't we have something like a
> nested loop, with AMs on one and reloptions on the other, where each
> reloption is tried on each AM and an exception block to report the
> failure or success for each case? Maybe have the list of AMs queried
> from pg_am with hardcoded additions if needed?
>
> --
> Álvaro Herrera Valdivia, Chile — https://www.EnterpriseDB.com/
> "Ninguna manada de bestias tiene una voz tan horrible como la humana" (Orual)
>
>

--
greg

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Greg Stark 2022-03-31 19:17:06 Re: jsonpath syntax extensions
Previous Message Greg Stark 2022-03-31 19:00:58 Re: [PATCH] pgbench: add multiconnect option