| From: | "Gregory Stark (as CFM)" <stark(dot)cfm(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Andrey Borodin <amborodin86(at)gmail(dot)com>, Pavel Borisov <pashkin(dot)elfe(at)gmail(dot)com>, Andrey Borodin <x4mmm(at)yandex-team(dot)ru>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Jakub Wartak <Jakub(dot)Wartak(at)tomtom(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Kirill Reshke <reshke(at)double(dot)cloud>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Use fadvise in wal replay |
| Date: | 2023-04-09 03:01:24 |
| Message-ID: | CAM-w4HNM5WwXxf34KgeYZpmwxeDDvF9H9csg9Q8yhAXz=cmfVA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, 19 Jan 2023 at 18:19, Andres Freund <andres(at)anarazel(dot)de> wrote:
>
> On 2023-01-19 22:19:10 +0100, Tomas Vondra wrote:
>
> > So I'm a bit unsure about this patch. I doesn't seem like it can perform
> > better than read-ahead (although perhaps it does, on a different storage
> > system).
>
> I really don't see the point of the patch as-is.
...
> I don't disagree fundamentally. But that doesn't make this patch a useful
> starting point.
It sounds like this patch has gotten off on the wrong foot and is not
worth moving forward to the next commitfest. Hopefully a starting over
from a different approach might target i/o that is more amenable to
fadvise. I'll mark it RwF.
--
Gregory Stark
As Commitfest Manager
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2023-04-09 04:16:58 | Re: Proposal: %T Prompt parameter for psql for current time (like Oracle has) |
| Previous Message | Thomas Munro | 2023-04-09 02:56:53 | Re: Direct I/O |