Re: [HACKERS] GSoC 2017 : Patch for predicate locking in Gist index

On 8 January 2018 at 23:13, Shubham Barai <shubhambaraiss(at)gmail(dot)com> wrote:

>
>
> On 8 January 2018 at 22:44, Shubham Barai <shubhambaraiss(at)gmail(dot)com>
> wrote:
>
>>
>>
>> On 5 January 2018 at 03:18, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru
>> > wrote:
>>
>>> On Thu, Jan 4, 2018 at 7:07 PM, Andrey Borodin <x4mmm(at)yandex-team(dot)ru>
>>> wrote:
>>>
>>>> 29 нояб. 2017 г., в 22:50, Shubham Barai <shubhambaraiss(at)gmail(dot)com>
>>>> написал(а):
>>>>
>>>> I have fixed formatting style. Please take a look at updated patch.
>>>>
>>>>
>>>> Here's rebased patch. Every issue has been addressed, so I'm marking
>>>> this patch as ready for committer.
>>>>
>>>
>>> I'm sorry for concentrating on boring things, but formatting of
>>> predicate-gist.spec still doesn't look good for me.
>>>
>>> # To verify serialization failures, queries and permutations are written
>>>> in such
>>>> # a way that an index scan(from one transaction) and an index
>>>> insert(from another
>>>> # transaction) will try to access the same part(sub-tree) of the index.
>>>> #
>>>> # To check reduced false positives, queries and permutations are
>>>> written in such
>>>> # a way that an index scan(from one transaction) and an index
>>>> insert(from another
>>>> # transaction) will try to access different parts(sub-tree) of the
>>>> index.
>>>>
>>>
>>> No space before open bracket (I think it should be when there are
>>> multiple words brackets).
>>> Also, we're trying to fit our lines to 80 characters (if it's not
>>> objectively difficult).
>>> And these are two almost same paragraphs. I think it should be
>>> simplified.
>>>
>>> setup
>>>> {
>>>> create table gist_point_tbl(id int4, p point);
>>>> create index gist_pointidx on gist_point_tbl using gist(p);
>>>> insert into gist_point_tbl (id, p)
>>>> select g, point(g*10, g*10) from generate_series(1, 1000) g;
>>>> }
>>>> setup
>>>> {
>>>> BEGIN ISOLATION LEVEL SERIALIZABLE;
>>>> set enable_seqscan=off;
>>>> set enable_bitmapscan=off;
>>>> set enable_indexonlyscan=on;
>>>> }
>>>> setup {
>>>> BEGIN ISOLATION LEVEL SERIALIZABLE;
>>>> set enable_seqscan=off;
>>>> set enable_bitmapscan=off;
>>>> set enable_indexonlyscan=on;
>>>> }
>>>
>>>
>>> I didn't get idea of using various indentation styles for same purpose.
>>>
>>> step "wx3" { insert into gist_point_tbl (id, p)
>>>> select g, point(g*500, g*500) from
>>>> generate_series(12, 18) g; }
>>>
>>>
>>> Indented using spaces here...
>>>
>>>
>>
>>
> I have fixed formatting issues. Please have a look at updated patch.
>
>
The previous patch couldn't be applied cleanly because there were some
modifications to isolation_schedule. I have updated the patch now.

Regards,
Shubham