Re: Switching XLog source from archive to streaming when primary available

On Tue, Feb 20, 2024 at 11:54 AM Japin Li <japinli(at)hotmail(dot)com> wrote:
>
>
> On Tue, 20 Feb 2024 at 13:40, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
> > On Mon, Feb 19, 2024 at 8:25 PM Japin Li <japinli(at)hotmail(dot)com> wrote:
> >> [2]
> >> +# Ensure checkpoint doesn't come in our way
> >> +$primary->append_conf('postgresql.conf', qq(
> >> + min_wal_size = 2MB
> >> + max_wal_size = 1GB
> >> + checkpoint_timeout = 1h
> >> + autovacuum = off
> >> +));
> >>
> >> Keeping the same indentation might be better.
> >
> > The autovacuum line looks mis-indented in the patch file. However, I
> > now ran src/tools/pgindent/perltidyrc
> > src/test/recovery/t/041_wal_source_switch.pl on it.
> >
>
> Thanks for updating the patch. It seems still with the wrong indent.

Thanks. perltidyrc didn't complain about anything on v19. However, I
kept the alignment same as other TAP tests for multi-line append_conf.
If that's not correct, I'll leave it to the committer to decide. PSA
v20 patch.

--
Bharath Rupireddy
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com