| From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
|---|---|
| To: | Zhihong Yu <zyu(at)yugabyte(dot)com> |
| Cc: | Japin Li <japinli(at)hotmail(dot)com>, David Steele <david(at)pgmasters(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: EXPLAIN/EXPLAIN ANALYZE REFRESH MATERIALIZED VIEW |
| Date: | 2021-03-08 04:28:56 |
| Message-ID: | CALj2ACXJ8S3gK34_-508kCcM=Zw9gy0c0SR5usacrq+QdS+r0w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Mar 7, 2021 at 10:13 PM Zhihong Yu <zyu(at)yugabyte(dot)com> wrote:
> Hi,
>
> + * EXPLAIN ANALYZE CREATE TABLE AS or REFRESH MATERIALIZED VIEW
> + * WITH NO DATA is weird.
>
> Maybe it is clearer to spell out WITH NO DATA for both statements, instead of sharing it.
Done that way.
> - if (!stmt->skipData)
> + if (!stmt->skipData && !explainInfo)
> ...
> + else if (explainInfo)
>
> It would be cleaner to put the 'if (explainInfo)' as the first check. That way, the check for skipData can be simplified.
Changed.
Thanks for review comments. Attaching v7 patch set with changes only
in 0002 patch. Please have a look.
With Regards,
Bharath Rupireddy.
EnterpriseDB: http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| v7-0001-Rearrange-Refresh-Mat-View-Code.patch | application/octet-stream | 18.0 KB |
| v7-0002-EXPLAIN-EXPLAIN-ANALYZE-REFRESH-MATERIALIZED-VIEW.patch | application/octet-stream | 17.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Smith | 2021-03-08 04:34:00 | Re: [HACKERS] logical decoding of two-phase transactions |
| Previous Message | Michael Paquier | 2021-03-08 03:33:38 | Re: Track replica origin progress for Rollback Prepared |