Re: Parallel copy

From: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
To: vignesh C <vignesh21(at)gmail(dot)com>
Cc: Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Ants Aasma <ants(at)cybertec(dot)at>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Alastair Turner <minion(at)decodable(dot)me>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Parallel copy
Date: 2020-06-25 03:00:14
Message-ID: CALj2ACXHbY_d5-=Pya52ZRvVqoko41LFYcXbM0m9aFkDLeXqfw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jun 24, 2020 at 2:16 PM Bharath Rupireddy
<bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
>
> Hi,
>
> It looks like the parsing of newly introduced "PARALLEL" option for
> COPY FROM command has an issue(in the
> 0002-Framework-for-leader-worker-in-parallel-copy.patch),
> Mentioning ....PARALLEL '4ar2eteid'); would pass with 4 workers since
> atoi() is being used for converting string to integer which just
> returns 4, ignoring other strings.
>
> I used strtol(), added error checks and introduced the error "
> improper use of argument to option "parallel"" for the above cases.
>
> parallel '4ar2eteid');
> ERROR: improper use of argument to option "parallel"
> LINE 5: parallel '1\');
>
> Along with the updated patch
> 0002-Framework-for-leader-worker-in-parallel-copy.patch, also
> attaching all the latest patches from [1].
>
> [1] - https://www.postgresql.org/message-id/CALj2ACW94icER3WrWapon7JkcX8j0TGRue5ycWMTEvgA3X7fOg%40mail.gmail.com
>

I'm sorry, I forgot to attach the patches. Here are the latest series
of patches.

With Regards,
Bharath Rupireddy.
EnterpriseDB: http://www.enterprisedb.com

Attachment Content-Type Size
0001-Copy-code-readjustment-to-support-parallel-copy.patch application/octet-stream 16.8 KB
0002-Framework-for-leader-worker-in-parallel-copy.patch application/octet-stream 33.8 KB
0003-Allow-copy-from-command-to-process-data-from-file-ST.patch application/octet-stream 40.4 KB
0004-Documentation-for-parallel-copy.patch application/octet-stream 2.0 KB
0005-Tests-for-parallel-copy.patch application/octet-stream 20.3 KB
0006-Parallel-Copy-For-Binary-Format-Files.patch application/octet-stream 24.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii Masao 2020-06-25 03:34:16 Re: Review for GetWALAvailability()
Previous Message Tom Lane 2020-06-25 02:50:39 Re: should libpq also require TLSv1.2 by default?