Re: New Table Access Methods for Multi and Single Inserts

From: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
To: Dilip Kumar <dilipbalaut(at)gmail(dot)com>
Cc: Luc Vlaming <luc(at)swarm64(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Paul Guo <guopa(at)vmware(dot)com>, Jeff Davis <pgsql(at)j-davis(dot)com>
Subject: Re: New Table Access Methods for Multi and Single Inserts
Date: 2021-03-10 04:51:53
Message-ID: CALj2ACX0fvSAxiGB8_yDsXo7JHSaDNUSHwH9OEpiMgnrynaP+g@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Mar 9, 2021 at 1:45 PM Bharath Rupireddy
<bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
> On Mon, Mar 8, 2021 at 6:37 PM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
>>
> > Why do we need to invent a new version table_insert_v2? And also why
> > it is named table_insert* instead of table_tuple_insert*?
>
> New version, because we changed the input parameters, now passing the
> params via TableInsertState but existing table_tuple_insert doesn't do
> that. If okay, I can change table_insert_v2 to table_tuple_insert_v2?
> Thoughts?

Changed table_insert_v2 to table_tuple_insert_v2. And also, rebased
the patches on to the latest master.

Attaching the v4 patch set. Please review it further.

With Regards,
Bharath Rupireddy.
EnterpriseDB: http://www.enterprisedb.com

Attachment Content-Type Size
v4-0001-New-Table-AMs-for-Multi-and-Single-Inserts.patch application/x-patch 19.4 KB
v4-0002-CTAS-and-REFRESH-Mat-View-With-New-Multi-Insert-T.patch application/x-patch 6.0 KB
v4-0003-COPY-With-New-Multi-and-Single-Insert-Table-AM.patch application/x-patch 22.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2021-03-10 04:54:41 Re: pgbench: option delaying queries till connections establishment?
Previous Message Amit Kapila 2021-03-10 04:16:35 Re: pgsql: Enable parallel SELECT for "INSERT INTO ... SELECT ...".