| From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, pg(at)bowt(dot)ie, melanieplageman(at)gmail(dot)com, boekewurm+postgres(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Add pg_walinspect function with block info columns |
| Date: | 2023-03-27 07:42:39 |
| Message-ID: | CALj2ACX0LaZ8o5PN9cXX13wK85md6z4oQiD5NSjQfkz6Msedvg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Mar 27, 2023 at 9:49 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Sat, Mar 25, 2023 at 12:12:50PM +0900, Michael Paquier wrote:
> > I don't see any need to move this block of code? This leads to
> > unnecessary diffs, potentially making backpatch a bit harder. Either
> > way is not a big deal, still.. Except for this bit, 0001 looks fine
> > by me.
>
> FYI, I have gone through 0001 and applied it, after tweaking a bit the
> part about block references so as we have only one
> XLogRecHasAnyBlockRefs, with its StringInfoData used only locally.
Thanks. Here's the v6 patch (last patch that I have with me for
pg_walinspect) for adding per-record info to pg_get_wal_block_info.
Note that I addressed all review comments received so far. Any
thoughts?
--
Bharath Rupireddy
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
| Attachment | Content-Type | Size |
|---|---|---|
| v6-0001-Emit-WAL-record-info-via-pg_get_wal_block_info.patch | application/x-patch | 12.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Smith | 2023-03-27 07:56:09 | Re: Data is copied twice when specifying both child and parent table in publication |
| Previous Message | Michael Paquier | 2023-03-27 07:23:38 | Re: Generate pg_stat_get_xact*() functions with Macros |