Re: Refactor "mutually exclusive options" error reporting code in parse_subscription_options

From: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Peter Smith <smithpb2250(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Amul Sul <sulamul(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Refactor "mutually exclusive options" error reporting code in parse_subscription_options
Date: 2021-07-01 15:55:41
Message-ID: CALj2ACWji0GaKGsUnnhzX66quM4u3bRC_dd9CtyEyORgKvc+0A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jul 1, 2021 at 6:32 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> > 3) There's an whitespace introduced making the SUBOPT_SLOT_NAME,
> > SUBOPT_SYNCHRONOUS_COMMIT and SUBOPT_STREAMING not falling line with
> > the SUBOPT_CONNECT
> >
>
> okay, will fix it.

PSA v11 patch which also has the cleanup patch shared by Alvaro Herrera.

Regards,
Bharath Rupireddy.

Attachment Content-Type Size
v11-0001-Refactor-function-parse_subscription_options.patch application/octet-stream 27.4 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Mark Dilger 2021-07-01 15:59:02 Re: Delegating superuser tasks to new security roles (Was: Granting control of SUSET gucs to non-superusers)
Previous Message David Christensen 2021-07-01 15:54:02 Re: pgbench: INSERT workload, FK indexes, filler fix