| From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Amul Sul <sulamul(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Refactor "mutually exclusive options" error reporting code in parse_subscription_options |
| Date: | 2021-06-02 12:41:39 |
| Message-ID: | CALj2ACWYMfGeiRy23tQAPgRHHrzC72q8Ynr4HUksfUa2ywBT3w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jun 2, 2021 at 11:43 AM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
> Yes, it looks better, but (since the masks are all 1 bit) I was only
> asking why not do like:
>
> if (supported_opts & SUBOPT_CONNECT)
> if (supported_opts & SUBOPT_ENABLED)
> if (supported_opts & SUBOPT_SLOT_NAME)
> if (supported_opts & SUBOPT_COPY_DATA)
Please review the attached v3 patch further.
With Regards,
Bharath Rupireddy.
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Refactor-parse_subscription_options.patch | application/octet-stream | 27.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Joel Jacobson | 2021-06-02 12:46:08 | Re: security_definer_search_path GUC |
| Previous Message | Joe Wildish | 2021-06-02 12:19:17 | Re: [PATCH] Allow queries in WHEN expression of FOR EACH STATEMENT triggers |