| From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
|---|---|
| To: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Cc: | alvherre(at)alvh(dot)no-ip(dot)org, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Add LSN along with offset to error messages reported for WAL file read/write/validate header failures |
| Date: | 2022-09-29 14:13:28 |
| Message-ID: | CALj2ACWRcU2A2dmrhKEZXX4OMXAP39eOL1oXTUvZ-yhn46L7xw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Sep 27, 2022 at 8:31 AM Kyotaro Horiguchi
<horikyota(dot)ntt(at)gmail(dot)com> wrote:
>
> If all error-emitting site knows the LSN, we don't need the context
> message. But *I* would like that the additional message looks like
> "while reading record at LSN %X/%X" or slightly shorter version of
> it. Because the targetRecPtr is the beginning of the current reading
> record, not the LSN for the segment and offset. It may point to past
> segments.
I think we could just say "LSN %X/%X, offset %u", because the overall
context whether it's being read or written is implicit with the other
part of the message.
Please see the attached v1 patch.
--
Bharath Rupireddy
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Add-LSN-along-with-offset-to-error-messages-repor.patch | application/x-patch | 7.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ronan Dunklau | 2022-09-29 14:15:25 | Re: A potential memory leak on Merge Join when Sort node is not below Materialize node |
| Previous Message | Tom Lane | 2022-09-29 14:10:03 | Re: A potential memory leak on Merge Join when Sort node is not below Materialize node |