From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
---|---|
To: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)fujitsu(dot)com>, houzj(dot)fnst(at)fujitsu(dot)com, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: Inaccurate error message when set fdw batch_size to 0 |
Date: | 2021-07-15 14:24:41 |
Message-ID: | CALj2ACWAqiNKFvvTpDxs5PHxGykQGcTB2FsU+Q=63BAx6LY+9A@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, Jul 12, 2021 at 10:11 PM Bharath Rupireddy
<bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
>
> On Mon, Jul 12, 2021 at 9:20 PM Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote:
> > + <simplesect>
> > + <title>Avoid Using <quote>non-negative</quote> Word in Error Messages</title>
> > +
> > + <para>
> > + Do not use <quote>non-negative</quote> word in error messages as it looks
> > + ambiguous. Instead, use <quote>foo must be an integer value greater than zero</quote>
> > + or <quote>foo must be an integer value greater than or equal to zero</quote>
> > + if option <quote>foo</quote> expects an integer value.
> > + </para>
> > + </simplesect>
> >
> > It seems suitable to put this guide under "Tricky Words to Avoid"
> > rather than adding it as separate section. Thought?
>
> +1. I will change.
PSA v7 patch with the above change.
Regards,
Bharath Rupireddy.
Attachment | Content-Type | Size |
---|---|---|
v7-0001-Disambiguate-error-messages-that-use-non-negative.patch | application/octet-stream | 8.6 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Bharath Rupireddy | 2021-07-15 14:26:47 | Re: Use WaitLatch for {pre, post}_auth_delay instead of pg_usleep |
Previous Message | Ranier Vilela | 2021-07-15 14:19:51 | Re: [PATCH] Use optimized single-datum tuplesort in ExecSort |