Re: Inaccurate error message when set fdw batch_size to 0

On Thu, Jul 15, 2021 at 7:54 PM Bharath Rupireddy
<bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
>
> On Mon, Jul 12, 2021 at 10:11 PM Bharath Rupireddy
> <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
> >
> > On Mon, Jul 12, 2021 at 9:20 PM Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote:
> > > + <simplesect>
> > > + <title>Avoid Using <quote>non-negative</quote> Word in Error Messages</title>
> > > +
> > > + <para>
> > > + Do not use <quote>non-negative</quote> word in error messages as it looks
> > > + ambiguous. Instead, use <quote>foo must be an integer value greater than zero</quote>
> > > + or <quote>foo must be an integer value greater than or equal to zero</quote>
> > > + if option <quote>foo</quote> expects an integer value.
> > > + </para>
> > > + </simplesect>
> > >
> > > It seems suitable to put this guide under "Tricky Words to Avoid"
> > > rather than adding it as separate section. Thought?
> >
> > +1. I will change.
>
> PSA v7 patch with the above change.

PSA v8 patch rebased on to latest master.

Regards,
Bharath Rupireddy.