| From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Peter Smith <smithpb2250(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Amul Sul <sulamul(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Refactor "mutually exclusive options" error reporting code in parse_subscription_options |
| Date: | 2021-06-01 14:55:16 |
| Message-ID: | CALj2ACVzJVF9ns9gou-UwoAC0c4GM-wvQwGnLE5KB0gQ0G6EdQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, May 24, 2021 at 7:04 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> Please see a3dc926 and the surrounding discussion for reasons why we've
> been using bitmaps for option parsing lately.
Thanks for the suggestion. Here's a WIP patch implementing the
subscription command options as bitmaps similar to what commit a3dc926
did. Thoughts?
If the attached WIP patch seems reasonable, I would also like to
implement a similar idea for the parse_publication_options although
there are only two options right now. Thoughts?
With Regards,
Bharath Rupireddy.
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-WIP-refactor-parse_subscription_options.patch | application/octet-stream | 27.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2021-06-01 15:35:44 | Re: Skipping logical replication transactions on subscriber side |
| Previous Message | Dilip Kumar | 2021-06-01 14:30:42 | Re: Decoding speculative insert with toast leaks memory |