Re: [PATCH] postgres_fdw connection caching - cause remote sessions linger till the local session exit

From: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
To: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
Cc: Zhihong Yu <zyu(at)yugabyte(dot)com>, Alexey Kondratov <a(dot)kondratov(at)postgrespro(dot)ru>, "Hou, Zhijie" <houzj(dot)fnst(at)cn(dot)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH] postgres_fdw connection caching - cause remote sessions linger till the local session exit
Date: 2021-02-22 05:55:31
Message-ID: CALj2ACVaE52Fwv4ArMgQWPkOVeVx3C7bmG-sqL_UOu=OOM8p4Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Feb 4, 2021 at 9:36 AM Bharath Rupireddy
<bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
>
> On Wed, Feb 3, 2021 at 4:22 PM Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote:
> > Maybe my explanation in the previous email was unclear. What I think is; If the server-level option is explicitly specified, its setting is used whatever GUC is. On the other hand, if the server-level option is NOT specified, GUC setting is used. For example, if we define the server as follows, GUC setting is used because the server-level option is NOT specified.
> >
> > CREATE SERVER loopback FOREIGN DATA WRAPPER postgres;
> >
> > If we define the server as follows, the server-level setting is used.
> >
> > CREATE SERVER loopback FOREIGN DATA WRAPPER postgres OPTIONS (keep_connections 'on');
>
> Attaching v20 patch set. Now, server level option if provided
> overrides the GUC.The GUC will be used only if server level option is
> not provided. And also, both server level option and GUC are named the
> same - "keep_connections".
>
> Please have a look.

Attaching v21 patch set, rebased onto the latest master.

With Regards,
Bharath Rupireddy.
EnterpriseDB: http://www.enterprisedb.com

Attachment Content-Type Size
v21-0002-postgres_fdw-add-keep_connections-GUC-to-not-cac.patch application/octet-stream 8.9 KB
v21-0003-postgres_fdw-server-level-option-keep_connection.patch application/octet-stream 12.5 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2021-02-22 06:04:42 Re: a misbehavior of partition row movement (?)
Previous Message Craig Ringer 2021-02-22 05:38:52 Re: libpq compression