| From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Use "WAL segment" instead of "log segment" consistently in user-facing messages |
| Date: | 2022-07-19 09:13:59 |
| Message-ID: | CALj2ACVTtH9HamzzYTSFuEopeh77homm3mW2fx13QPnsnGAKUg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jul 19, 2022 at 12:00 AM Nathan Bossart
<nathandbossart(at)gmail(dot)com> wrote:
>
> Overall, these patches look reasonable.
>
> On Mon, Jul 18, 2022 at 04:24:12PM +0530, Bharath Rupireddy wrote:
> > record. Because the entire content of data pages is saved in the
> > - log on the first page modification after a checkpoint (assuming
> > + WAL record on the first page modification after a checkpoint (assuming
> > <xref linkend="guc-full-page-writes"/> is not disabled), all pages
> > changed since the checkpoint will be restored to a consistent
> > state.
>
> nitpick: I would remove the word "record" in this change.
Done. PSA v5 patch set.
Regards,
Bharath Rupireddy.
| Attachment | Content-Type | Size |
|---|---|---|
| v5-0001-Use-WAL-segment-instead-of-log-segment.patch | application/octet-stream | 9.0 KB |
| v5-0002-Replace-log-record-with-WAL-record-in-docs.patch | application/octet-stream | 17.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrey Lepikhov | 2022-07-19 09:35:22 | Re: Fast COPY FROM based on batch insert |
| Previous Message | tanghy.fnst@fujitsu.com | 2022-07-19 09:02:07 | Memory leak fix in psql |