| From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Remove extra Logging_collector check before calling SysLogger_Start() |
| Date: | 2021-12-03 07:58:25 |
| Message-ID: | CALj2ACV9J=bwTrJJPc+nr6SBijsnoCCMB2Lf7xE6tJ7gShnzew@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
It seems like there's an extra Logging_collector check before calling
SysLogger_Start(). Note that the SysLogger_Start() has a check to
return 0 if Logging_collector is off. This change is consistent with
the other usage of SysLogger_Start().
/* If we have lost the log collector, try to start a new one */
- if (SysLoggerPID == 0 && Logging_collector)
+ if (SysLoggerPID == 0)
SysLoggerPID = SysLogger_Start();
Attaching a tiny patch to fix. Thoughts?
Regards,
Bharath Rupireddy.
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-remove-extra-Logging_collector-check-before-SysLo.patch | application/octet-stream | 804 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2021-12-03 08:13:14 | Re: Remove extra Logging_collector check before calling SysLogger_Start() |
| Previous Message | tanghy.fnst@fujitsu.com | 2021-12-03 07:54:06 | RE: Alter all tables in schema owner fix |