| From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
|---|---|
| To: | japin <japinli(at)hotmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, "Hou, Zhijie" <houzj(dot)fnst(at)cn(dot)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Logical Replication - behavior of ALTER PUBLICATION .. DROP TABLE and ALTER SUBSCRIPTION .. REFRESH PUBLICATION |
| Date: | 2021-01-15 11:55:44 |
| Message-ID: | CALj2ACUTtpwXzny_5Gix4sgSCj=2BaV=F__WeTSGL6zxSbaPNg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jan 15, 2021 at 4:54 PM japin <japinli(at)hotmail(dot)com> wrote:
> On Fri, 15 Jan 2021 at 18:57, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> wrote:
> > On Fri, Jan 15, 2021 at 4:03 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> >> That sounds like a better way to fix and in fact, I was about to
> >> suggest the same after reading your previous email. I'll think more on
> >> this but in the meantime, can you add the test case in the patch as
> >> requested earlier as well.
> >
> > @Li Japin Please let me know if you have already started to work on
> > the test case, otherwise I can make a 0002 patch for the test case and
> > post.
> >
>
> Yeah, I'm working on the test case. Since I'm not familair with the logical
> replication test, it may take some times.
Thanks a lot. I quickly added the initial use case where we saw the
bug, attached is 0002 patch. Please have a look and add further use
cases if necessary. If okay, it's better to make a cf entry.
I have one comment in v3-0001 patch,
+ * There might some relations dropped from the publication, we do
I think we should change it to - "There might be some relations".
With Regards,
Bharath Rupireddy.
EnterpriseDB: http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0002-Test-behaviour-of-ALTER-PUBLICATION-.-DROP-TABLE.patch | application/octet-stream | 3.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro Horiguchi | 2021-01-15 12:22:58 | Re: Wrong HINT during database recovery when occur a minimal wal. |
| Previous Message | Sergei Kornilov | 2021-01-15 11:28:56 | Re: Improve handling of parameter differences in physical replication |