| From: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | Amit Langote <amitlangote09(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Performance Improvement For Copy From Binary Files |
| Date: | 2020-07-13 14:58:03 |
| Message-ID: | CALj2ACULf3JEx+eD9xncJ0H-6w6Ep7-ypywotp2AaHrYVxrsxw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
>
> I had one small comment:
> +{
> + int copied_bytes = 0;
> +
> +#define BUF_BYTES (cstate->raw_buf_len - cstate->raw_buf_index)
> +#define DRAIN_COPY_RAW_BUF(cstate, dest, nbytes)\
> + do {\
> + memcpy((dest), (cstate)->raw_buf +
> (cstate)->raw_buf_index, (nbytes));\
> + (cstate)->raw_buf_index += (nbytes);\
> + } while(0)
>
> BUF_BYTES could be used in CopyLoadRawBuf function also.
>
Thanks Vignesh for the find out. I changed and attached the v5 patch.
The regression tests(make check and make check-world) ran
successfully.
With Regards,
Bharath Rupireddy.
EnterpriseDB: http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| CopyFrom-binary-buffering_v5.patch | application/x-patch | 9.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2020-07-13 14:58:50 | Re: WIP: BRIN multi-range indexes |
| Previous Message | Daniel Gustafsson | 2020-07-13 14:57:41 | Re: proposal: possibility to read dumped table's name from file |